Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: made the startup probe consistent for nodespec and druidspec #122

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix: made the startup probe consistent for nodespec and druidspec #122

merged 1 commit into from
Dec 26, 2023

Conversation

avtarOPS
Copy link
Contributor

@avtarOPS avtarOPS commented Dec 26, 2023 •
edited
Loading

Fixes #119

Description

Made the spelling of startup probe config consistent for nodeSpec and druidSpec.

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
Key changed/added files in this PR
  • apis/druid/v1alpha1/druid_types.go
  • apis/druid/v1alpha1/zz_generated.deepcopy.go
  • chart/templates/crds/druid.apache.org_druids.yaml
  • config/crd/bases/druid.apache.org_druids.yaml
  • config/druid.apache.org_druids.yaml
  • controllers/druid/handler.go
  • docs/api_specifications/druid.md
  • e2e/configs/druid-mmless.yaml
  • examples/tiny-cluster-mmless.yaml

@AdheipSingh AdheipSingh merged commit 81ac979 into datainfrahq:master Dec 26, 2023
1 check passed
@SatyaKuppam
Copy link
Contributor

Is this change backwards compatible?

  • What will happen to existing clusters that have startUpProbes in them when we upgrade?
  • Should we expect them to start failing?

@AdheipSingh
Copy link
Contributor

@SatyaKuppam
Change is not backward compatible, any change in CR spec is not backward compatible. ( unless there are conversion webhooks )

  • Pls change your CR, to add startUpProbe

To do such changes, you should

  • Scale down operator to zero
  • Apply or edit CR with startUpProbe
  • Upgrade operator version.

This way the current state remains as it is. Nodes should not restart.

Ill try to document this. Thanks for asking this question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdheipSingh AdheipSingh AdheipSingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make startup probes consistent
3 participants
@avtarOPS @SatyaKuppam @AdheipSingh